Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(ci): migrate from abandoned actions-rs/* #6628

Merged
merged 2 commits into from
May 10, 2023
Merged

refactor(ci): migrate from abandoned actions-rs/* #6628

merged 2 commits into from
May 10, 2023

Conversation

gustavovalverde
Copy link
Member

Motivation

All Rust related repositories at actions-rs/* are no longer being maintained

Fixes: #6048

Solution

Review

Anyone from @ZcashFoundation/devops-reviewers

Reviewer Checklist

  • Will the PR name make sense to users?
    • Does it need extra CHANGELOG info? (new features, breaking changes, large changes)
  • Are the PR labels correct?
  • Does the code do what the ticket and PR says?
    • Does it change concurrent code, unsafe code, or consensus rules?
  • How do you know it works? Does it have tests?

@gustavovalverde gustavovalverde added C-bug Category: This is a bug A-devops Area: Pipelines, CI/CD and Dockerfiles P-High 🔥 C-deprecation Category: Old features that will soon be gone labels May 8, 2023
@gustavovalverde gustavovalverde self-assigned this May 8, 2023
@gustavovalverde gustavovalverde requested a review from a team as a code owner May 8, 2023 14:18
@gustavovalverde gustavovalverde requested review from teor2345 and removed request for a team May 8, 2023 14:18
@github-actions github-actions bot added C-trivial Category: A trivial change that is not worth mentioning in the CHANGELOG C-deprecated labels May 8, 2023
@codecov
Copy link

codecov bot commented May 8, 2023 •
edited
Loading

Codecov Report

Merging #6628 (e1191d3) into main (6016c9d) will increase coverage by 0.21%.
The diff coverage is 88.57%.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #6628      +/-   ##
==========================================
+ Coverage   77.92%   78.13%   +0.21%     
==========================================
  Files         309      309              
  Lines       40653    40664      +11     
==========================================
+ Hits        31678    31772      +94     
+ Misses       8975     8892      -83

teor2345
teor2345 reviewed May 8, 2023
View reviewed changes
.github/workflows/lint.yml Outdated Show resolved Hide resolved
teor2345
teor2345 reviewed May 8, 2023
View reviewed changes
.github/workflows/lint.yml Outdated Show resolved Hide resolved
teor2345
teor2345 reviewed May 8, 2023
View reviewed changes
.github/workflows/lint.yml Outdated Show resolved Hide resolved
teor2345
teor2345 suggested changes May 8, 2023
View reviewed changes
Copy link
Contributor

@teor2345 teor2345 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think removing the clippy annotations is a blocker. Can we please keep them?

@teor2345
Copy link
Contributor

teor2345 commented May 8, 2023

What's the deadline for this? Have GitHub announced a final date when support for these actions will end?

@gustavovalverde
Copy link
Member Author 

I think removing the clippy annotations is a blocker. Can we please keep them?

I kept it, as this is a blocker and we have time to find a better replacement.

What's the deadline for this? Have GitHub announced a final date when support for these actions will end?

September 27th

teor2345
teor2345 approved these changes May 10, 2023
View reviewed changes
Copy link
Contributor

@teor2345 teor2345 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

I reduced the priority to "medium", because the deadline is still 4 months away.

mergify bot added a commit that referenced this pull request May 10, 2023
@mergify
Merge of #6628
edbeb85
@mergify mergify bot mentioned this pull request May 10, 2023
Closed
mergify bot added a commit that referenced this pull request May 10, 2023
@mergify
Merge of #6628
413f926
@mergify mergify bot mentioned this pull request May 10, 2023
Closed
mergify bot added a commit that referenced this pull request May 10, 2023
@mergify
Merge of #6628
46a3c1a
@mergify mergify bot mentioned this pull request May 10, 2023
Closed
@mergify mergify bot merged commit 25ca4cc into main May 10, 2023
@mergify mergify bot deleted the fix-deprecated-action branch May 10, 2023 14:25
@teor2345
Copy link
Contributor

@gustavovalverde is this PR causing internal errors in GitHub actions:

GitHub Actions has encountered an internal error when running your job.

https://github.com/ZcashFoundation/zebra/actions/runs/4940550408?pr=6657

Or is that happening because of the current GitHub infrastructure failures:
https://www.githubstatus.com/

@teor2345 teor2345 mentioned this pull request May 10, 2023
Merged
6 tasks
teor2345 added a commit that referenced this pull request May 10, 2023
@teor2345
Revert "refactor(ci): migrate from abandoned actions-rs/* (#6628)"
3c797c3 
This reverts commit 25ca4cc.
@teor2345 teor2345 mentioned this pull request May 10, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@teor2345 teor2345 teor2345 approved these changes

Assignees

@gustavovalverde gustavovalverde

Labels
A-devops Area: Pipelines, CI/CD and Dockerfiles C-bug Category: This is a bug C-deprecation Category: Old features that will soon be gone C-trivial Category: A trivial change that is not worth mentioning in the CHANGELOG
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ci: migrate actions using the unmaintained actions-rs/* repository
2 participants
@gustavovalverde @teor2345